Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

used a yellow box when the query number reaches 50 #96

Merged
merged 1 commit into from Jul 30, 2012

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Jul 30, 2012

Sometimes one just adds a row in its template table wich was not fetched in the query, with the doctrine magic it's being fetched but the number of queries just exploses...

Having an highlighted tip insteady of the gray may catch the developer's attention on that, I realize it's not so good to hardcore it, as 50 is just my personal point of view, but maybe we can make this warning number limit configurable in the doctrine bridge collector?

@stof
Copy link
Member

stof commented Jul 30, 2012

I think it is a great idea.

@beberlei @guilhermeblanco do you think making it configurable is worth it or should we keep it hardcoded for the sake of simplicity ?

@guilhermeblanco
Copy link
Member

@stof I liked the idea. +1 from me

@stof
Copy link
Member

stof commented Jul 30, 2012

@guilhermeblanco my question is not whether we should add the feature (I have no doubt about it) but whether we should make the limit configurable for the user of the bundle :)

@guilhermeblanco
Copy link
Member

@stof I think we should enforce it. If we have too many complains later, we can work on this support.
It's a good starting point IMHO. 50 queries is a good number.

@stof
Copy link
Member

stof commented Jul 30, 2012

Ok, then merging.

stof added a commit that referenced this pull request Jul 30, 2012
used a yellow box when the query number reaches 50
@stof stof merged commit ed8d02b into doctrine:master Jul 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants