Allow Symfony 5.0 #158
Allow Symfony 5.0 #158
Conversation
|
Merging this PR until we have removed the dependency on this bundle from DoctrineBundle. The decision to deprecate this bundle and not add support for Symfony 5 (as indicated in #156) still stands: this PR will be reverted once we've removed the dependency mentioned above. |
This PR was merged into the 5.0-dev branch. Discussion ---------- Bump Symfony 5.0 to PHP 7.2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Not ready yet. 7.2 because it has all we need for the next two years (7.3 doesn't provide anything we absolutely need, and 7.4 is not even released so cannot be considered yet.) 7.2.9 because of https://tracker.debian.org/pkg/php7.2 Needs: - [x] symfony/security-acl#48 - [x] doctrine/orm#7723 - [x] doctrine/DoctrineBundle#975 - [x] doctrine/DoctrineCacheBundle#158 - [x] symfony#31657 Commits ------- d94d9d7 Bump Symfony 5.0 to PHP 7.2
|
Can a new tagged release be made to reflect this merged PR? |
|
Well, we should tag a release, otherwise DoctrineBundle cannot be installed in a Symfony 5 project without people adding a root requirement on DoctrineCacheBundle to whitelist its dev version, which will actually make the deprecation harder. |
The dependency has been removed as of the 2.0 release: doctrine/DoctrineBundle#1029 |
|
Oh, I forgot that. Then it is fine. |
Until this is completely removed from DoctrineBundle, let's allow the Symfony 5.0 CI to pass.
Sibling of doctrine/DoctrineBundle#975