Fixes missing Symfony 7 (BETA3) type-hint for the Command to load the fixtures #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Nov 11, 2023
greg0ire
force-pushed
the
DavidGarciaCat-SF7-Command-Type-Hints
branch
from
731a7aa
to
fdd7057
Compare
greg0ire
force-pushed
the
DavidGarciaCat-SF7-Command-Type-Hints
branch
from
fdd7057
to
4d4f738
Compare
greg0ire
approved these changes
Nov 11, 2023
|
Didn't we fix that with #402? 🤔 |
|
see #408 |
|
Oh yes, sorry! |
|
Cheers, guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source code in branch 4.0.x does not match with the Symfony 7 type-hint requirements to use the bundle's command.
This PR sets them to make sure this bundle is compatible with the framework.