Add a simple Confirmation if --append option isn't set #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a simple Confirmation if --append option isn't set
|
This breaks things when the input is not interactive (as it will wait for the confirmation forever). You need to add this check only conditionally. |
|
what do you think about adding a --forced option like for the doctrine:schema:update. I guess it could prevent mistakes |
|
you don't need a force. You simply need to check if the input is interactive before asking confirmation (the DoctrineMigrationsBundle does it) |
|
Ok done, I didn't know this interactive method. Thanks for the tip |
| @@ -68,6 +68,15 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
| $doctrine = $this->getContainer()->get('doctrine'); | |||
| $em = $doctrine->getManager($input->getOption('em')); | |||
|
|
|||
| if ($input->isInteractive()) { | |||
| if (!$input->getOption('append')){ | |||
There was a problem hiding this comment.
you should use && instead of nesting 2 if
|
done |
stof
added a commit
that referenced
this pull request
Aug 20, 2012
Add a simple Confirmation if --append option isn't set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple Confirmation if --append option isn't set