Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility layer for v3.x #294

Merged
merged 5 commits into from Mar 28, 2020
Merged

Conversation

goetas
Copy link
Member

@goetas goetas commented Dec 22, 2019

This PR adds the new cofiguration options available in 3.x (see #278) and deprecates the current settings.

This should allow a smooth transition to 3.x

@goetas goetas force-pushed the forward-compat-v3 branch 2 times, most recently from f9aa427 to 4e963e1 Compare December 22, 2019 20:25
@goetas goetas added this to the 2.2.0 milestone Dec 22, 2019
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
Resources/doc/index.rst Show resolved Hide resolved
@goetas goetas changed the base branch from master to 2.1.x March 6, 2020 21:54
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@greg0ire
Copy link
Member

Please check the SA Travis job, it's failing.

@goetas
Copy link
Member Author

goetas commented Mar 16, 2020

Silenced the static analysis in 0512c5e since the symfony phpdoc is just wrong

@goetas goetas requested a review from greg0ire March 16, 2020 08:29
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goetas
Copy link
Member Author

goetas commented Mar 18, 2020

using both phpstyle and phpstan style typehints to make both phpstan and phpcs happy
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using both phpstyle and phpstan style typehints to make both phpstan and phpcs happy

Weird that we have a rule that prevents that, maybe this should be reported to the coding standard repository? Anyway, if there is no phpstan exception, great!

@goetas goetas changed the base branch from 2.1.x to 2.2.x March 28, 2020 09:37
@goetas goetas merged commit ddcc1c5 into doctrine:2.2.x Mar 28, 2020
@goetas goetas deleted the forward-compat-v3 branch March 28, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants