New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward compatibility layer for v3.x #294
Conversation
f9aa427
to
4e963e1
Compare
4e963e1
to
40d722f
Compare
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
Please check the SA Travis job, it's failing. |
Silenced the static analysis in 0512c5e since the symfony phpdoc is just wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please drop 0512c5e and fix the SA issue by changing the type hint that is here: https://github.com/doctrine/DoctrineMigrationsBundle/blob/master/DependencyInjection/DoctrineMigrationsExtension.php#L25 there is no type hint in Symfony for this: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Extension/ExtensionInterface.php
0512c5e
to
e89a4e5
Compare
Like this 54598cd ? |
using both phpstyle and phpstan style typehints to make both phpstan and phpcs happy
e89a4e5
to
54598cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using both phpstyle and phpstan style typehints to make both phpstan and phpcs happy
Weird that we have a rule that prevents that, maybe this should be reported to the coding standard repository? Anyway, if there is no phpstan exception, great!
This PR adds the new cofiguration options available in 3.x (see #278) and deprecates the current settings.
This should allow a smooth transition to 3.x