Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new doctrine current command #317

Merged
merged 2 commits into from Apr 24, 2020
Merged

Add new doctrine current command #317

merged 2 commits into from Apr 24, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Apr 24, 2020

Integrates doctrine/migrations#965 into the bundle

@goetas goetas added this to the 3.0.0 milestone Apr 24, 2020
@greg0ire
Copy link
Member

Shouldn't the doctrine/migrations requirement be bumped?

@goetas
Copy link
Member Author

goetas commented Apr 24, 2020

Currently we are requiting doctrine/migrations:^3.0@dev, until 3.0.0 is not released, no version bump is required

@goetas
Copy link
Member Author

goetas commented Apr 24, 2020

But only now i see the test failure... but i have no idea how to fix it...

@greg0ire
Copy link
Member

Besides pinning to a given commit, I have no idea either

@greg0ire
Copy link
Member

Ah wait I know, try to use master. Right now it's installing the alpha1 tag, which matches @dev

@goetas
Copy link
Member Author

goetas commented Apr 24, 2020

like this?

@greg0ire
Copy link
Member

yeah I think that should work

@goetas
Copy link
Member Author

goetas commented Apr 24, 2020

yeah

greg0ire
greg0ire approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a squash merge for this

@goetas goetas merged commit f9b4c06 into doctrine:master Apr 24, 2020
@goetas goetas deleted the current-migrations-command branch April 24, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goetas @greg0ire