New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that container aware migrations are not special anymore #348
Conversation
cea6e27
to
bfdd240
Compare
This information might be relevant for the documentation too. I don't know in which chapter it would fit in though. |
@SenseException i could not find any reference to this feature in the documentation, I think that was something available but never documented, so i've added a section to document that feature now. |
d37e422
to
5763db6
Compare
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
3644b1c
to
b4685e0
Compare
Is there anywhere I can read about the decision to remove support for injecting the Container? |
Not really. it has been done as part of the major refactoring done in v3. The rationale behind them is to remove the magic (some command injecting dependencies based on marker interfaces) and let people use dependency injection do the job by providing dependencies they might need. |
I have in plan to work on this and to provide a factory (enabled by default when using the bundle)that will provide the container if the migration is "container aware" |
#368 will introduce a default migration factory that will check if the migration class implements the |
closes #349
closes #350