Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that container aware migrations are not special anymore #348

Merged
merged 3 commits into from Jul 4, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Jun 26, 2020

closes #349
closes #350

@goetas goetas added this to the 3.0.2 milestone Jun 26, 2020
UPGRADE.md Outdated Show resolved Hide resolved
@SenseException
Copy link
Member

This information might be relevant for the documentation too. I don't know in which chapter it would fit in though.

@goetas
Copy link
Member Author

goetas commented Jun 27, 2020

@SenseException i could not find any reference to this feature in the documentation, I think that was something available but never documented, so i've added a section to document that feature now.

@goetas goetas marked this pull request as draft June 27, 2020 07:06
Resources/doc/index.rst Outdated Show resolved Hide resolved
Resources/doc/index.rst Outdated Show resolved Hide resolved
@goetas goetas requested a review from greg0ire July 4, 2020 08:42
@goetas goetas marked this pull request as ready for review July 4, 2020 08:42
@goetas goetas merged commit 9d365d0 into doctrine:3.0.x Jul 4, 2020
@fabpot
Copy link
Member

fabpot commented Jul 20, 2020

Is there anywhere I can read about the decision to remove support for injecting the Container?

@goetas
Copy link
Member Author

goetas commented Jul 20, 2020

@fabpot

Is there anywhere I can read about the decision to remove support for injecting the Container?

Not really. it has been done as part of the major refactoring done in v3. The rationale behind them is to remove the magic (some command injecting dependencies based on marker interfaces) and let people use dependency injection do the job by providing dependencies they might need.

@goetas
Copy link
Member Author

goetas commented Aug 1, 2020

I have in plan to work on this and to provide a factory (enabled by default when using the bundle)that will provide the container if the migration is "container aware"

@goetas
Copy link
Member Author

goetas commented Sep 16, 2020

#368 will introduce a default migration factory that will check if the migration class implements the ContainerAwareInterface class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants