toOne handles fieldset arrays nicely #241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
added a commit
that referenced
this pull request
May 14, 2013
|
@texdc can you rebase? |
Check for only collection valued association before throwing exception when adding strategy.
Unless I misunderstood, this makes more sense.
Add count Hack Change count As Selectable always load a whole collection to do a count, we just return 0. It's up to the developer, if he/she needs the complete count, to use a repostiroy for that Bring back
Change logic for strategies Remove useless check
* Since $findMethod already holds the $this->findMethod array, might as well use the local copy.
|
ack! can I ever get this rebase right? |
|
I can't seem to get this right. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #194
Squashed and rebased.