Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate doctrine/cache #786

Closed
Koen1999 opened this issue Jun 9, 2022 · 8 comments
Closed

Deprecate doctrine/cache #786

Koen1999 opened this issue Jun 9, 2022 · 8 comments

Comments

@Koen1999
Copy link

Koen1999 commented Jun 9, 2022

doctrine/cache v2.0.0 was released about a year ago and it's probably a good idea if doctrine/doctrine-module adds support for doctrine/cache ^2.

https://github.com/doctrine/cache/releases/tag/2.0.0

@driehle
Copy link
Member

driehle commented Jun 10, 2022

Please have a look at Doctrine cache's docs on what v2.0 actually is: https://www.doctrine-project.org/projects/doctrine-cache/en/2.2/index.html. There are no cache adapters/implementations anymore, just a few interfaces.

So what would you suggest should be implemented on the side of DoctrineModule?

@Koen1999
Copy link
Author

Probably it's a good idea to switch to another cache provider like the one from Symfony as suggested in the docs.
https://github.com/symfony/cache

@driehle
Copy link
Member

driehle commented Jul 4, 2022

Please provide a PR adding support for symfony/cache. I'll be happy to review and merge your PR.

@driehle driehle changed the title Add support for doctrine/cache ^2 Deprecate doctrine/cache and add symfony/cache Jul 4, 2022
@driehle driehle added Feature Request Help Wanted Extra attention is needed labels Jul 4, 2022
@driehle driehle added this to the 5.3.0 milestone Dec 8, 2022
@froschdesign
Copy link

@driehle
Maybe I'm misunderstanding something here, but why add symfony/cache here when that module is for Laminas and laminas-cache is already required?

"laminas/laminas-cache": "^3.6.0",

@driehle driehle changed the title Deprecate doctrine/cache and add symfony/cache Deprecate doctrine/cache Dec 9, 2022
@driehle
Copy link
Member

driehle commented Dec 9, 2022

Yes, you're right. I was rather thinking of adding symfony/cache as a second alternative. Currently, laminas-cache and doctrine/cache can be used, so laminas-cache and symfony/cache could be a replacement. Nevertheless, we should probably make one step at a time, so simply dropping/deprecating doctrine/cache would be the easiest step forward.

@fezfez
Copy link
Contributor

fezfez commented Dec 9, 2022

@driehle can it be done in next release ? 5.4 or 6.0 if BC ? it's currently blocking 5.3 release for no real reason

@driehle
Copy link
Member

driehle commented Dec 9, 2022

I'd like to have at least the deprecations in 5.3.0. I have already started working on this, so we'll still be able to release 5.3.0 over the weekend.

@TomHAnderson
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants