-
-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate doctrine/cache #786
Comments
Please have a look at Doctrine cache's docs on what v2.0 actually is: https://www.doctrine-project.org/projects/doctrine-cache/en/2.2/index.html. There are no cache adapters/implementations anymore, just a few interfaces. So what would you suggest should be implemented on the side of DoctrineModule? |
Probably it's a good idea to switch to another cache provider like the one from Symfony as suggested in the docs. |
Please provide a PR adding support for symfony/cache. I'll be happy to review and merge your PR. |
Yes, you're right. I was rather thinking of adding symfony/cache as a second alternative. Currently, laminas-cache and doctrine/cache can be used, so laminas-cache and symfony/cache could be a replacement. Nevertheless, we should probably make one step at a time, so simply dropping/deprecating doctrine/cache would be the easiest step forward. |
@driehle can it be done in next release ? 5.4 or 6.0 if BC ? it's currently blocking 5.3 release for no real reason |
I'd like to have at least the deprecations in 5.3.0. I have already started working on this, so we'll still be able to release 5.3.0 over the weekend. |
doctrine/cache
v2.0.0 was released about a year ago and it's probably a good idea ifdoctrine/doctrine-module
adds support fordoctrine/cache
^2
.https://github.com/doctrine/cache/releases/tag/2.0.0
The text was updated successfully, but these errors were encountered: