Simplified build matrix for continuous integration #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
force-pushed
the
feature/simplified-build-matrix
branch
from
216cc25
to
c180757
Compare
greg0ire
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amount of jobs and the type of jobs executed remains the same, but the build matrix is simplified and easier to read.
As a downside, the steps in the job get more complex. I still see this change as a benefit, as the log of the action will directly show when
--ignore-platform-req=phpwas used, which was not the case before. Furthermore, adding new PHP versions is much easier and cleaner now. So if there will be PHP 8.2, complexity will remain the same with this approach, while previously each additional PHP version causing troubles with laminas-cache would have further complexified the build matrix.