Drop container-interop/container-interop #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
force-pushed
the
feat/drop-container-interop
branch
from
c03472d
to
c72eedf
Compare
Ocramius
suggested changes
Nov 18, 2022
| @@ -37,7 +37,6 @@ | |||
| "homepage": "http://www.doctrine-project.org/", | |||
| "require": { | |||
| "php": "^7.4 || ~8.0.0 || ~8.1.0", | |||
| "container-interop/container-interop": "^1.2.0", | |||
There was a problem hiding this comment.
psr/container should become a dependency here, since we still reference it in src/
laminas-cache has change signatures from 3.6.0 to 3.8.0 by added the mixed type. This causes troubles for PhpStan, which identifies the mixed type being missing when executed with PHP 8.1. Ignoring these errors for now to keep compatibility with PHP 7.4.
driehle
force-pushed
the
feat/drop-container-interop
branch
from
c7a2aaf
to
9f02103
Compare
Ocramius
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops the dependency towards
container-interop/container-interop, which is abandonned.As a consequence, the interface
Interop\Container\ContainerInterfacedoes not exist anymore in favour ofPsr\Container\ContainerInterface. We follow the guidelines of laminas, which considers this to be a non-breaking change (see release notes of servicemanager 3.11.0).All affected signatures (besides unit tests) are internal or final, so there will be no issues for users.