Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP 8.3 #828

Merged
merged 6 commits into from Jan 17, 2024
Merged

Support for PHP 8.3 #828

merged 6 commits into from Jan 17, 2024

Conversation

TomHAnderson
Copy link
Member

No description provided.

@TomHAnderson TomHAnderson mentioned this pull request Jan 9, 2024
Closed
SenseException
SenseException approved these changes Jan 11, 2024
View reviewed changes
src/Form/Element/ObjectMultiCheckbox.php Outdated Show resolved Hide resolved
driehle
driehle requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@driehle driehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PHP version of the other workflows to 8.2, i.e. coding standards, static analysis and composer lint. They need to run with the latest version, as the minimal version is automatically inflected.

@TomHAnderson
Copy link
Member Author

Return types are now imported from Laminas types. Workflows updated to 8.2

@TomHAnderson TomHAnderson added this to the 6.0.8 milestone Jan 14, 2024
driehle
driehle approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@driehle driehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driehle driehle modified the milestones: 6.0.8, 6.1.0 Jan 17, 2024
@driehle
Copy link
Member

driehle commented Jan 17, 2024

This must be a new minor according to our rules, i.e. 6.1.0

@driehle driehle merged commit fc1f8f4 into doctrine:6.1.x Jan 17, 2024
12 checks passed
@arhimede arhimede mentioned this pull request Jan 17, 2024
Closed
@driehle driehle mentioned this pull request Jan 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

@driehle driehle driehle approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TomHAnderson @driehle @SenseException