Avoid failing lookups for empty array values (bis) #98
Conversation
|
@bakura10 hmm, still not really good since |
|
How can an empty string be a primary key ? Anyway, David use case have much higher chance than having an empty string as pk... Envoyé de mon iPhone Le 9 oct. 2012 à 19:53, Marco Pivetta notifications@github.com a écrit :
|
|
@bakura10 the fact is that there's an abyss between It is just a matter of being correct, but we have to deal with this data right now. |
|
But this is problematic. We just CANNOT don't hydrate a value because it is empty (just think of a field that you update by removing the value, you still have to set an empty value). So I think this fix covers the most usual case. |
|
Yep, still annoying :( Can you please add a comment there? After that I'll merge. @davidwindell thank you for this catch! |
|
Done. I have also updated the doc with a longer comment. |
|
Chaps, no problem! We've got a rather large API running so there's a heck of a lot of hydration going on bringing things like this to note. Going forward, would either of you be opposed to a PR that updates the Hydrator to implement the StrategyEnabledInterface so that we can apply custom Hydration strategies before rather than after the Doctrine Hydrator has passed the data. NB At the moment we apply our Hydration Strategies to the Class Methods hydrator attached so they occur after the case |
|
I completely follow you for this ! I wanted to do it a few weeks ago but completely forgotten ! This should be a great update and should not be a BC. |
|
This hydrator is becoming really good, I'm quite happy with the work we did with him ! Thanks everyone ;-) ! |
Avoid failing lookups for empty array values (bis)
|
Aaaaaand, it's done :) |
|
:) working really well, thank you @bakura10. I'll raise a PR for StrategyEnabledInterface |
|
Changes Unknown when pulling 1e0b4f6 on bakura10:hotfix97 into * on doctrine:master*. |
Fixed cache drivers that can be better configurable.
This is a corrected version of #97