Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setDefaultRepositoryClassName is not defined #298

Closed
zeliard91 opened this issue May 18, 2015 · 3 comments
Closed

setDefaultRepositoryClassName is not defined #298

zeliard91 opened this issue May 18, 2015 · 3 comments

Comments

@zeliard91
Copy link

The PR #297 added a call to Doctrine\ODM\MongoDB\Configuration::setDefaultRepositoryClassName() but this method is present only in "doctrine/mongo-odm":"dev-master" for the moment as it has been merged by doctrine/mongodb-odm#892), so after the tag 1.0.0-BETA12.

@malarzm I don't know if the PR should be 'reverted', maybe it's preferable to wait for a new doctrine/mongodb-odm release than change the version requirement to dev-master.

@malarzm
Copy link
Member

malarzm commented May 18, 2015

I'm thinking about checking if default_repository_class is different than default one and if so then add a call to Doctrine\ODM\MongoDB\Configuration::setDefaultRepositoryClassName() but also we will discuss the issue internally and try to provide the best fix.

@malarzm
Copy link
Member

malarzm commented May 22, 2015

@zeliard91 we have tagged v3.0.0 :)

@malarzm malarzm closed this as completed May 22, 2015
@zeliard91
Copy link
Author

@malarzm great job, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants