Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of the whole container #688

Closed
franmomu opened this issue Jul 28, 2021 · 3 comments
Closed

Remove usage of the whole container #688

franmomu opened this issue Jul 28, 2021 · 3 comments
Projects
Milestone

Comments

@franmomu
Copy link
Contributor

Right now CacheWarmers receive the whole container and also in Command:

abstract class DoctrineODMCommand extends Command implements ContainerAwareInterface
{
use ContainerAwareTrait;

it would be nice to inject only the used services and parameters and remove the usage of the whole container.

@stale
Copy link

stale bot commented Sep 6, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Sep 6, 2021
@franmomu franmomu removed the Stale Issues that have not seen any activity in 30 days label Sep 8, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues that have not seen any activity in 30 days label Apr 16, 2022
@franmomu franmomu removed the Stale Issues that have not seen any activity in 30 days label Apr 18, 2022
@IonBazan IonBazan added this to the 5.0.0 milestone May 9, 2022
@IonBazan
Copy link
Member

IonBazan commented May 9, 2022

This should be aiming v5.0 because commands are marked as @internal since then and container-related methods are marked for removal in v5:

/**
* @deprecated since version 4.4
*/
public function setContainer(?ContainerInterface $container = null)
{
trigger_deprecation(
'doctrine/mongodb-odm-bundle',
'4.4',
'The "%s" method is deprecated and will be dropped in DoctrineMongoDBBundle 5.0.',
__METHOD__
);
$this->container = $container;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
Awaiting triage
Development

No branches or pull requests

3 participants