New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed PHPUnit warnings in PHP >= 5.6 #167
Conversation
Corrected instance calling convention in test files with static invocation.
@Bilge sorry, what warning you get? You can check last travis build and all seems to be fine. |
|
@Bilge yes, it is since PHPUnit 5.4. As you can see library required PHPUnit 4.8 so at this moment all is good. |
@webimpress It is deprecated in the 4.x branch. |
I would not have changed it if it wasn't necessary. |
@Bilge Please check above resources and than re-thing if your change was necessary. BTW. From ZF conduct:
I think all libraries should contain this ... |
@webimpress Please get out of my PRs your commentary is unwelcome. |
Hello @Bilge , you are always too polite! We have to take a common street across modules for this feature. I close this PR right know and I will come back soon on your work with a cherry-pick if we decide to take this street. Thanks for your PR |
@gianarb I fail to see what difficulty you have in making a decision here. Short array syntax is available since PHP 5.4, for the past 4.5 years, and the minimum supported version has already moved on to 5.6. It should be an easy decision for anyone to make. |
This builds on #164 so you might want to merge that first so the diff doesn't look so muddy. Alternatively just review the relevant commit.