ZF3 compatibility #168
ZF3 compatibility #168
Conversation
| @@ -1,3 +1,3 @@ | |||
| vendor | |||
| composer.lock | |||
There was a problem hiding this comment.
Our other libraries don't commit composer.lock either, so I'd suggest leaving it out for the module as well.
There was a problem hiding this comment.
I think it is better to add the lockfile now, to have wider spectrum of tests, so we can make sure the library is compatible with all dependencies. Please have a look on comments here:
zendframework/zend-inputfilter#107 (comment)
There was a problem hiding this comment.
I'll let @gianarb decide on this one. Personally I'd be in favour of not committing the lock file and running tests with latest dependencies (as is the default in composer install without a lock file) and once with the --prefer-lowest flag set to install the lowest dependencies. This has multiple advantages: it makes sure the lower package constraints are still correct, and it would alleviate the problem Matthew indicated in the linked comment about developers not knowing if their PR broke due to their code changes or upstream package changes.
| "zendframework/zend-servicemanager": "2.*", | ||
| "zendframework/zend-stdlib": "2.*" | ||
| "php": "~5.6 || ~7.0", | ||
| "doctrine/doctrine-module": "dev-master", |
There was a problem hiding this comment.
Just a reminder that it would be much, much better if we had a stable version of doctrine-module we can require at this point.
There was a problem hiding this comment.
of course, once doctrine-module will be tagged I'll update it here, or it could be done before release :) thanks
There was a problem hiding this comment.
Huh? It's already tagged, isn't it?
There was a problem hiding this comment.
Not the one including doctrine/DoctrineModule#567, which includes compatibility with ZF3.
There was a problem hiding this comment.
No :( not yet, @gianarb merged DoctrineModule and DoctrineORMModule without tagging.
Please see his comment here: doctrine/DoctrineORMModule#491 (comment)
|
@gianarb what do you think about this PR? Can you review it and merge it please? |
|
Any news? |
|
@webimpress Is there anything we can do to help you out with this PR ? As far as I can tell the DoctrineModule supports ZF3 (thank you for the work) but waiting to be tagged. |
|
@respinoza This is ready, I think it could be merged to dev-master as others doctrine modules are. And probably it can be tagged after DoctrineModule release. I haven't experienced any issues in this library so far. |
|
Thanks @webimpress for your AMAZING work to help the doctrine community to enjoy ZF3. I have in plan to tag all our modules soon because we have a good amount of tests now 👍 |
|
Thank you for the merge. |
Added ZF3 compatibility but also kept ZF2 compatibility. PHP5.5 support dropped.
There is no any BC breaks ! ! ! 😄
It depends on doctrine/DoctrineModule#567
The only problem was with
zend-mvc-console(over ZF3) so please seesuggestsection incomposer.jsonand travis configuration.Thoughts?