Docker for all unit testing; ready for v2.0 for Laminas #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Feb 28, 2020
|
Ah I see you are in the middle of something, I will do my review later |
TomHAnderson
force-pushed
the
feature/laminas
branch
from
b4a6a94
to
634b177
Compare
TomHAnderson
force-pushed
the
feature/laminas
branch
from
8cb6133
to
f7ebb16
Compare
TomHAnderson
changed the title
TomHAnderson
changed the title
|
Ready for review now |
greg0ire
reviewed
Feb 29, 2020
greg0ire
reviewed
Feb 29, 2020
greg0ire
reviewed
Feb 29, 2020
greg0ire
reviewed
Feb 29, 2020
greg0ire
reviewed
Feb 29, 2020
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
TomHAnderson
changed the title
TomHAnderson
force-pushed
the
feature/laminas
branch
from
f44e6cb
to
44d237f
Compare
TomHAnderson
force-pushed
the
feature/laminas
branch
from
0c14d9c
to
16c900e
Compare
TomHAnderson
changed the title
|
This is ready for another review. |
greg0ire
reviewed
Mar 1, 2020
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
greg0ire
approved these changes
Mar 1, 2020
greg0ire
reviewed
Mar 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer changes; use PHP >= 7.2