Changed type hint from Cursor to Iterator in __construct #221
Conversation
|
Will fix: #190 |
| @@ -19,7 +20,7 @@ class DoctrinePaginator implements AdapterInterface | |||
| /** | |||
| * Constructor | |||
| */ | |||
| public function __construct(Cursor $cursor) | |||
| public function __construct(Iterator $cursor) | |||
There was a problem hiding this comment.
This makes no sense on its own, the class is still depending it'll get a Cursor instance
There was a problem hiding this comment.
The CommandCursor does not extend Cursor so it cannot be used in the DoctrinePaginator, which is the point of this change: #190
There was a problem hiding this comment.
Yeah but for one in count() method there's a call to $this->cursor->getBaseCursor() - from \Iterator's perspective there's no such method
There was a problem hiding this comment.
Alright. I'll close this PR and mark the issue as will not address.
|
Will not address this issue: #190 |
| @@ -19,7 +20,7 @@ class DoctrinePaginator implements AdapterInterface | |||
| /** | |||
| * Constructor | |||
| */ | |||
| public function __construct(Cursor $cursor) | |||
| public function __construct(Iterator $cursor) | |||
There was a problem hiding this comment.
This change seems to widen the scope of acceptance and can potentially break code, as on line 34 if this file you rely on an undefined Iterator method called getBaseCursor.
When widen acceptance scope, it's recommended to add a test that covers the baseline and make sure it supports the baseline properly. In this case, a direct simple implementation of Iterator
Following instructions @ Doctrine\ODM\MongoDB\Cursor
@deprecated This class is deprecated and will be removed in 2.0. You should typehint against the {@see Iterator} interface instead.