Annotation support for Validator and DoctrineEntity element

[bakura10]

Currently, when using Form annotation, there are no ways to specify the entity manager for Validator and DoctrineEntity Form elements. As the annotation builder has the em, I think it could be automatically injected ?

[Ocramius]

You'd build a new annotation builder. Specifying the entity manager to be used later on would be wrong.

[bakura10]

What ? There is already a specific annotation builder in DoctrineORMModule :).

[Ocramius]

Yes, but if you need a second EntityManager it is up to you to configure it with that, no?

[bakura10]

I don't want a second one. I just want one =).

[Ocramius]

So you basically want a setEntityManager on it?
Can you please elaborate your request a bit?

[bakura10]

Hmmm. Did you used the annotation form ? In fact, the NoEntityExists (as well as DoctrineORMModule\Form\Element\DoctrineEntity) needs an entity manager to work (otherwise they throw an exception).

However when using annotation, you cannot give instance to an option. BUT the Annotation builder in DoctrineORMModule (DoctrineORMModule\Form\Annotation\AnnotationBuilder) has an instance of the em. As this object checks every annotation to construct the form, it should be able to automatically inject the em to elements/validators that need it.

[Ocramius]

No, I didn't use the annotation builder, but the validators are something different from the builder itself. This anyway seems more like a job for the ElementAnnotationsListener (which should be instantiated with an EntityManager). My problem with all this stuff is that you're wiring it together :)
I don't really get how you would like these elements to be instantiated, but the EntityManager/ObjectManager should be explicitly set by the user in each case imo.

[Ocramius]

Closing. This should be (imo) handled through metadata instead. Please re-open if you got better ideas to fix this, but I'd really move away from the concept of annotations and instead have a builder instantiated with an ObjectManager as parameter.