Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to set the DC2Type- Comment on custom types #436

Closed
wants to merge 2 commits into from

Conversation

tommyseus
Copy link

Added a a new option to mark types as commented.
It will create the comment (DC2Type:point) on custom types.

Inspired by \Doctrine\Bundle\DoctrineBundle\ConnectionFactory

Config example:

return array(
    'doctrine' => array(
        'connection' => array(
            'orm_default' => array(
                'doctrineTypeMappings' => array(
                    'point' => 'string',
                ),
                'doctrineCommentedTypes' => array(
                    'point'
                ),
            ),
        ),
        'configuration' => array(
            'orm_default' => array(
                'types' => array(
                    'point' => '\MyNamespace\PointType',
                ),
            ),
        ),
    ),
);

@Ocramius
Copy link
Member

@gianarb looks good to me (except for missing tests)

@Ocramius Ocramius added this to the 1.0.0 milestone Sep 30, 2015
@gianarb gianarb mentioned this pull request Oct 1, 2015
@gianarb
Copy link
Contributor

gianarb commented Oct 1, 2015

Replace with #437

@gianarb gianarb closed this Oct 1, 2015
oprokidnev pushed a commit to oprokidnev/DoctrineORMModule that referenced this pull request Apr 19, 2016
Fixing typo and updating paginator link to ZF 2.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants