Add jackalope.factory to the DI extension #27
Conversation
| @@ -162,7 +174,7 @@ private function loadJackalopeSession(array $session, ContainerBuilder $containe | |||
| } | |||
| if (isset($session['backend']['disable_transactions'])) { | |||
| $parameters['jackalope.disable_transactions'] = $session['backend']['disable_transactions']; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Sorry, I didn't clearly describe my use case. What I need to override is the factory NOT the RepositoryFactory. The line you highlighted is the one that creates the RepositoryFactory factory service (which could be RepositoryFactoryJackrabbit or the doctrinedbal option). The pull request I submitted overrides the "factory" that the RepositoryFactory uses to build the transport.
If you open the Jackalope\RepositoryFactoryJackrabbit class then navigate to the getRepository method, it takes the following parameters:
- jackalope.factory
- jackalope.default_header
- jackalope.jackrabbit_expect
- jackalope.check_login_on_server
- jackalope.disable_stream_wrapper
The DI extension of the bundle has support for some of the parameters, but the "jackalope.factory" is not there.
There was a problem hiding this comment.
i do understand your use case and i am very much looking forward to what you will enable with this change.
i was asking you to revert the whitespace change.
|
interesting PR .. aside from the whitespace change it looks good to merge to me. may i ask about your use case? |
|
I'm trying to switch the Http layer of the Jackalope/Jackrabbit transport to use the Guzzle Http framework. The factory is the one that provides all the Jackalope entities including the transport client and its request. By injecting a custom factory into the RepositoryFatcory through its parameters, the transport changes will be totally transparent to Jacakalope. |
|
ah very cool. there is a fairly old ticket for this: jackalope/jackalope#33 |
| if (class_exists($session['backend']['factory'])) { | ||
| $parameters['jackalope.factory'] = $session['backend']['factory']; | ||
| } else { | ||
| $parameters['jackalope.factory'] = new Reference($session['backend']['factory']); |
There was a problem hiding this comment.
does it make sense to create a service implicitly? just asking because i never saw this.
There was a problem hiding this comment.
it seems OK to me. the error message should be clear enough in case of a misconfigiration. obviously this needs some docs too
|
definitely +1 on the PR, makes sense. @aabdou: is the factory itself documented well enough to implement your own? i don't know if we have assumptions somewhere or the interface could be incomplete. but if it works for you, then its already a good sign :-) |
Add jackalope.factory to the DI extension
|
thanks for this contribution! |
The Jackalope/Jackrabbit repository factory supports the jackalope.factory factory that could be used to override the factory class the Jackrabbit transport uses. A valid class name or an instance of a class that implements the FactoryInterface are two valid options for the jackalope.factory parameter.