Added image type #37

elHornair · 2013-02-22T10:45:39Z

This PR adds an phpcr odm image type that can be used in forms to upload an image that is stored in a PHPCR repository.

dbu · 2013-02-22T10:47:00Z

Document/Image.php

@@ -0,0 +1,61 @@
+<?php
+
+namespace Doctrine\Bundle\PHPCRBundle\Document;


should we put the Image Document into phpcr-odm itself? (this is really a question, i am not sure if it makes much sense)

Hmm, I don't know either :)

Can we leave it here for now and move it when its needed somewhere else?

moving would be a BC break so not ideal. any opinions, @lsmith77 ?

lets put it into the ODM since we already have a couple of documents there. i guess we can then also default to this inside CreateBundle?

Ok, will do. Yes, the one in CreateBundle looks pretty much the same

Added PR to ODM: doctrine/phpcr-odm#250

Great, thank you. Now this PR is not considered WIP anymore. Or is there something left that should be adapted?

dbu · 2013-02-23T11:27:53Z

Resources/views/Form/fields.html.twig

@@ -0,0 +1,4 @@
+{% block phpcr_image_widget %}
+    {{ form_widget(form) }}
+    <img src="{{ form.vars.data | imagine_filter('image_upload_thumbnail') }}" alt="" />


what happens with this widget if i have not yet uploaded an image?

and what is the standard way with the symfony Form to distinguish between "user did not upload a new file" and "user wants to remove that file"?

is this imagine filter using the copy of the image, so in the end file system to display it?

Uh yeah, if I have not yet uploaded an image, I still try to display it - will fix.

I don't know how we can distinguish between "no new file uploaded" and "file should be removed" - does someone know? Maybe add a checkbox to explicitly delete it?

Yes, imagine_filter uses a file system copy. Will try to add a listener to make sure we clear the imagine cache whenever a new image gets set

dbu · 2013-02-23T11:30:47Z

how exactly does it work with showing the image? is the imagine filter fine for all? or do we need an image controller? should we port https://github.com/symfony-cmf/CreateBundle/blob/master/Controller/PHPCRImageController.php here? or should all go through imagine?

dantleech · 2013-02-23T17:27:09Z

Form/DataTransformer/ModelToFileTransformer.php

+
+class ModelToFileTransformer implements DataTransformerInterface
+{
+


No need for blank line here I think

rmsint · 2013-02-25T09:04:14Z

Wow, really nice. It would be usefull to also provide an option to delete the image. This can be used when an image is not required: the user uploaded one and then does not want the image anymore. Here is a gist from a project, could save some time if you want to add it: https://gist.github.com/rmsint/ad4d8804e3ae6fae2160

dbu · 2013-02-25T09:40:07Z

ah cool. so you just add another field to the form to explicitly delete. sounds reasonable. when/where do you actually delete the image in your gist? can we access that in the data transformer?

the event listener sounds not straightforward for me. ah, or do we need it and can't make it in the custom type directly because we don't know at that point if we will have data or not?

stof · 2013-02-25T09:42:42Z

@dbu the type cannot handle data. It is about configuring the Form object, so it occurs before using the Form object. As you need to access the data to determine whether the field should be added, it can only be done later.

elHornair · 2013-02-25T12:44:45Z

Nice @rmsint thx for that gist, will try to add this. However there are two things that are unclear to me:

Where do you actually delete the image when the checkbox is checked? (what @dbu already asked)
Did you also have the problem that in edit mode the image will be deleted (overridden by null) if you don't upload a new image? I don't understand how I could tell the form component "There is no new image, just keep the old".

rmsint · 2013-02-25T14:18:17Z

the checkbox is mapped to the setRemoveFile method on the object containing the image. I now realize this was not an image object but something like the slide object embedding the image, sorry... If the checkbox is checked it does not really makes sense to delete the file from the image object, an empty image object will then be referenced from fe. a slide object. And I think you then want the image object to be removed. Maybe you can still implement it only then have to document that the method removeFile (or something else) should be implemented on the parent of the image object? A bit the same as the collection type has the "allow_delete" option.
no, but I followed most of the solution from the symfony cookbook for ORM: http://symfony.com/doc/current/cookbook/doctrine/file_uploads.html. The difference is that the file is stored on the filesystem and not in the document. Anyhow, it works this way:
- an image object has a file property for uploads that is not persisted
- then prePersist and preUpdate methods take care of handling a new file upload and will result in setting the path property of the image object
- in edit mode when null is set to the file property, nothing will happen to the path property and the file on the filesystem

dantleech · 2013-02-25T18:21:35Z

Is this type only for "updloaded" documents? What about documents that already exist, e.g. a user avatar? Should this be renamed to "phpcr_odm_image_upload" so that we can free up "phpcr_odm_image" to display, change and remove existing images?

dbu · 2013-02-26T09:48:50Z

@dantleech well the type is to handle images in forms. which usually means uploading the image. i think the only other thing that could be would be providing the image by url and have the server grab it from there, but that is rather the special case. the Image document could be used for other contexts than the image form type we discuss here. but when would you need a phpcr_odm_image form type whithout uploading?

@rmsint thanks for the clarifications. so i guess we have to do the same in our Image document, not remove the file on null but have a removeFile method that can be triggered by the checkbox. @elHornair do you think you can manage that? guess we need to update the document in phpcr-odm as well.

dantleech · 2013-02-26T12:45:26Z

Well, you might want to change the image reference to another existing image, for example another in a media library. In that case the media library would handle the upload.

Envoyé de mon téléphone Android avec K-9 Mail. Excusez la brièveté.

David Buchmann notifications@github.com a écrit :

@dantleech well the type is to handle images in forms. which usually means uploading the image. i think the only other thing that could be would be providing the image by url and have the server grab it from there, but that is rather the special case. the Image document could be used for other contexts than the image form type we discuss here. but when would you need a phpcr_odm_image form type whithout uploading?

@rmsint thanks for the clarifications. so i guess we have to do the same in our Image document, not remove the file on null but have a removeFile method that can be triggered by the checkbox. @elHornair do you think you can manage that? guess we need to update the document in phpcr-odm as well.

—
Reply to this email directly or view it on GitHub.

dbu · 2013-02-26T13:34:01Z

ok, i see. but that would then be a sonata_media_image or something, or not?

dbu · 2013-02-26T14:50:38Z

for the documentation, this would belong into this section: http://symfony.com/doc/master/cmf/bundles/phpcr-odm.html#form-types

dantleech · 2013-02-26T19:54:26Z

Hmm... the more I think about this the less sure I am that it should belong here, after all, there is nothing Image specific in the ODM. I would imagine that it might fit better into something like a symfony-cmf/MediaBundle. I think that this PR also adds a dependence on the imagine library also no?, which shouldn't be associated with DoctrinePHPCRODM in my opinion. What do you think? Sorry to be negative :(

Burgov · 2013-02-27T11:04:48Z

imagine should probably be added to composer.json?

dbu · 2013-02-27T11:13:04Z

@dantleech thanks for voicing concerns, better now than being sorry later. i think for the full scale media management, there is SonataMediaBundle which people are working on integrating with the cmf. this is just a small piece and it does bring the Image document of phpcr-odm into the form layer, so i think here is the right place. we create no hard dependency on imagine:

@Burgov yes, alain is going to add a suggest entry for imagine.

if people do not want to use the form type, they do not need imagine, so its not creating a new hard dependency. we could even add an option to configure if you want preview - without preview there is no imagine needed at all.

@rmsint i will extract your gist and suggestion into a new ticket, atm we will just delete the whole document to get rid of the image (that really depends on the use case what makes sense, so your suggestion has value and should be implemented, but we can't do everything right now, as much as i would wish so...)

elHornair · 2013-02-27T12:24:38Z

Did the cleanup. Thanks a lot for your explanations @rmsint

Added image type

dbu · 2013-02-27T15:21:17Z

i created #40 to keep the information from rmsint regarding the delete file checkbox. its a cool idea and if somebody has time would be a nice addition.

dbu · 2013-02-27T15:40:29Z

doc started here symfony-cmf/symfony-cmf-docs#97

dantleech · 2013-02-27T16:18:42Z

@dbu I didn't realise the PHPCR-ODM had an Image class, so this PR makes sense to me now :)

added image document, type, tranformer and template

55175f3

dbu reviewed Feb 22, 2013
View reviewed changes

Alain Horner added 4 commits February 22, 2013 11:58

use mimetype from file instead of own property

24c9645

phpdoc and type hinting

f7ffa8d

switched to meaningful filtername

0d75618

ImageDocument was moved to ODM

c19886d

elHornair mentioned this pull request Feb 22, 2013

added image document doctrine/phpcr-odm#250

Merged

dbu reviewed Feb 23, 2013
View reviewed changes

dantleech reviewed Feb 23, 2013
View reviewed changes

dbu mentioned this pull request Feb 24, 2013

[WIP] sonata media example symfony-cmf/cmf-sandbox#159

Closed

Alain Horner added 3 commits February 25, 2013 13:09

ws and cs

7465da9

using correct prefix

f3a07e1

dont render image if there is none :)

ca32a7f

Alain Horner added 2 commits February 27, 2013 13:01

added suggestion for imagine bundle

b30cc72

misc

8f63f75

dbu added a commit that referenced this pull request Feb 27, 2013

Merge pull request #37 from elHornair/image_type

41f4939

Added image type

dbu merged commit 41f4939 into doctrine:master Feb 27, 2013

dbu mentioned this pull request Feb 27, 2013

allow deletion in phpcr_odm_image form type #40

Closed

dbu mentioned this pull request Jun 21, 2013

allow deletion in image form type symfony-cmf/media-bundle#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added image type #37

Added image type #37

elHornair commented Feb 22, 2013

dbu Feb 22, 2013

elHornair Feb 22, 2013

dbu Feb 22, 2013

lsmith77 Feb 22, 2013

elHornair Feb 22, 2013

elHornair Feb 22, 2013

lsmith77 Feb 22, 2013

elHornair Feb 23, 2013

dbu Feb 23, 2013

elHornair Feb 25, 2013

dbu commented Feb 23, 2013

dantleech Feb 23, 2013

elHornair Feb 25, 2013

rmsint commented Feb 25, 2013

dbu commented Feb 25, 2013

stof commented Feb 25, 2013

elHornair commented Feb 25, 2013

rmsint commented Feb 25, 2013

dantleech commented Feb 25, 2013

dbu commented Feb 26, 2013

dantleech commented Feb 26, 2013

dbu commented Feb 26, 2013

dbu commented Feb 26, 2013

dantleech commented Feb 26, 2013

Burgov commented Feb 27, 2013

dbu commented Feb 27, 2013

elHornair commented Feb 27, 2013

dbu commented Feb 27, 2013

dbu commented Feb 27, 2013

dantleech commented Feb 27, 2013

		@@ -0,0 +1,61 @@
		<?php

		namespace Doctrine\Bundle\PHPCRBundle\Document;


		class ModelToFileTransformer implements DataTransformerInterface
		{

Added image type #37

Added image type #37

Conversation

elHornair commented Feb 22, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dbu commented Feb 23, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmsint commented Feb 25, 2013

dbu commented Feb 25, 2013

stof commented Feb 25, 2013

elHornair commented Feb 25, 2013

rmsint commented Feb 25, 2013

dantleech commented Feb 25, 2013

dbu commented Feb 26, 2013

dantleech commented Feb 26, 2013

Well, you might want to change the image reference to another existing image, for example another in a media library. In that case the media library would handle the upload.

dbu commented Feb 26, 2013

dbu commented Feb 26, 2013

dantleech commented Feb 26, 2013

Burgov commented Feb 27, 2013

dbu commented Feb 27, 2013

elHornair commented Feb 27, 2013

dbu commented Feb 27, 2013

dbu commented Feb 27, 2013

dantleech commented Feb 27, 2013