Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AnnotationReader] Traits Composed from Traits #81

Open
guilhermeblanco opened this issue Mar 27, 2016 · 4 comments
Open

[AnnotationReader] Traits Composed from Traits #81

guilhermeblanco opened this issue Mar 27, 2016 · 4 comments
Labels
bug

Comments

@guilhermeblanco
Copy link
Member

From @sofakartoffel on June 23, 2015 15:34

The AnnotationReader does not use the imports from Traits inside of other Traits.

e.g.:

  • TraitA imports some custom annotation
  • TraitB uses TraitA
  • EntityA uses TraitB
  • the Imported Annotation in TraitA is not found

Copied from original issue: doctrine/common#370
@guilhermeblanco guilhermeblanco mentioned this issue Mar 27, 2016
Closed
hboomsma pushed a commit to hboomsma/annotations that referenced this issue Oct 27, 2016
Fix for issue doctrine#81 Traits Composed from Traits
8d10181 
Use statements are now also imported for properties
and methods from traits in traits. Conflict resolution
and aliases are respected.

For backwards compatibility reasons the use statements
from the declaring class are still merged. PHP itself 
does not show this behaviour regarding to imported types
in traits.
hboomsma pushed a commit to hboomsma/annotations that referenced this issue Oct 27, 2016
Fix for issue doctrine#81 Traits Composed from Traits
12dc813 
Use statements are now also imported for properties
and methods from traits in traits. Conflict resolution
and aliases are respected.

For backwards compatibility reasons the use statements
from the declaring class are still merged. PHP itself 
does not show this behaviour regarding to imported types
in traits.
hboomsma pushed a commit to hboomsma/annotations that referenced this issue Oct 27, 2016
Fix for issue doctrine#81 Traits Composed from Traits
2dc9b9b 
Use statements are now also imported for properties
and methods from traits in traits. Conflict resolution
and aliases are respected.

For backwards compatibility reasons the use statements
from the declaring class are still merged. PHP itself 
does not show this behaviour regarding to imported types
in traits.
@hboomsma hboomsma mentioned this issue Oct 27, 2016
Closed
@Majkl578 Majkl578 added this to the v2.0.0 milestone Oct 16, 2018
@zakjakub
Copy link

zakjakub commented Dec 3, 2018

Any workaround? :/

@Ocramius
Copy link
Member

Ocramius commented Dec 3, 2018

@zakjakub revive #102 (rebase it and prepare it for merge)?

@Ocramius Ocramius added the bug label Dec 3, 2018
@zakjakub
Copy link

zakjakub commented Dec 3, 2018

@Ocramius Thanks, I had opened many tabs with same title and overlooked that one! 👍

@Majkl578 Majkl578 mentioned this issue Dec 18, 2018
Closed
27 tasks
@DerDu
Copy link

DerDu commented Nov 19, 2019

Just a quick referencing of issues on the same topic

@janlam7 janlam7 mentioned this issue Dec 23, 2019
Merged
@PowerKiKi PowerKiKi mentioned this issue May 8, 2020
Closed
@alcaeus alcaeus removed this from the 2.0.0 milestone May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Majkl578 @Ocramius @guilhermeblanco @alcaeus @DerDu @zakjakub