Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving phpunit task from before_script to script in .travis.yml #7

Merged

Conversation

Ocramius
Copy link
Member

As @stof said in #6, phpunit should be in script, and not in before_script in .travis.yml. Sorry about that :\

@@ -6,4 +6,6 @@ php:

before_script:
- composer --prefer-source --dev install

script:
- phpunit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can even remove it as it is the default script for PHP builds

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://travis-ci.org/doctrine/annotations/jobs/7362837 where Travis ran twice: once in your before-script, and once in the default script (as there was no explicit script)

@stof
Copy link
Member

stof commented May 28, 2013

@beberlei @guilhermeblanco 👍 Running phpunit twice is useless

Ocramius added a commit that referenced this pull request Mar 3, 2014
…o-script

Moving phpunit task from before_script to script in .travis.yml
@Ocramius Ocramius merged commit 316b956 into doctrine:master Mar 3, 2014
@Ocramius Ocramius self-assigned this Mar 3, 2014
@Ocramius Ocramius deleted the hotfix/build-from-before_script-to-script branch March 3, 2014 13:00
@Ocramius Ocramius added this to the v1.2.0 milestone Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants