Split up remaining pieces in public/index.php #15
Conversation
| { | ||
| public function __invoke(string $buildDir) : void | ||
| { | ||
| (new Process(['rm', '-rf', $buildDir])) |
There was a problem hiding this comment.
At this point, we need to assert that $buildDir is a directory, before performing something this scary :)
| public function __invoke( | ||
| UriInterface $repositoryUri, | ||
| string $targetPath, | ||
| string $gitAuthorName, |
There was a problem hiding this comment.
These values should be asserted upon, or we should have value types introduced
| public function __invoke( | ||
| string $repositoryDirectory, | ||
| BranchName $sourceBranch, | ||
| string $tagName, |
There was a problem hiding this comment.
We need to assert on the tag being a non-empty string
As you can see from the structure of the code that was ported, it is extremely hard to test in isolation. That will be a pain, but we'll need to go through it. Also, I think that the various |
|
Cool. That is aligned with what I was thinking needs to happen next. I will keep working on it. |
|
Closing here: this has been implemented in laminas/automatic-releases#1, which splits the application into multiple independent CLI commands. |
Fixes #4
TODO: