Make all annotations useful by default

[Majkl578]

Slevomat CS 5.0 drops usefulAnnotations so we are forced to switch to allAnnotationsAreUseful instead.
From now on there is no whitelist for useful annotations, only the blacklist provided by ForbiddenAnnotations.

Sadly I'm still not convinced this is a good step forward though.

[alcaeus]

🤷‍♂️

Only option I see is creating a new sniff maintained by us that keeps old behaviour. Other than that, nothing we can do.

[morozov]

@Majkl578 could you provide a reference to the discussion of the deprecation?

[lcobucci]

I honestly fail to see the value of maintaining a whitelist and a blacklist, do think this is a good thing.

[SenseException]

@ORM\
This one is more about a fix alias for Doctrine annotations, which is used by the documentation, but excludes other alias choices for the same annotations. Technically, the annotations of Doctrine were excluded.

[Majkl578]

@morozov I don't think there was discussion about this - it was deprecated at the moment allAnnotationsAreUseful was added: slevomat/coding-standard@85ca537. We'd need to ask @kukulich himself.

[kukulich]

There was discussion among all Slevomat CS developers so between me and nobody else :D It's better to have special (and smaller) sniffs to solve special tasks. ForbiddenAnnotationsSniff is better. There's always possibility to implemented new whitelist option for the ForbiddenAnnotationsSniff

[carusogabriel]

Why didn't we update to Slevomat/CS v5.0 first?

[Majkl578]

@carusogabriel Because this was pre-requisite for the upgrade.