Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SpreadOperatorSpacing sniff #111

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Enable SpreadOperatorSpacing sniff #111

merged 1 commit into from
Feb 8, 2019

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Feb 8, 2019

Simple sniff to check that ellipsis are not followed by spacing - see tests.

@Majkl578 Majkl578 added this to the 6.0.0 milestone Feb 8, 2019
@Majkl578 Majkl578 requested a review from a team as a code owner February 8, 2019 14:40
carusogabriel
carusogabriel approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@carusogabriel carusogabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🤘

Ocramius
Ocramius approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Ocramius Ocramius merged commit 6b50008 into master Feb 8, 2019
@Ocramius Ocramius deleted the sniff/SpreadOperatorSpacing branch February 8, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morozov morozov morozov approved these changes

@Ocramius Ocramius Ocramius approved these changes

@ostrolucky ostrolucky ostrolucky approved these changes

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees
No one assigned
Labels
New rule
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Majkl578 @morozov @Ocramius @ostrolucky @carusogabriel