Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI failure when phpcbf cannot fix the file #115

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Trigger CI failure when phpcbf cannot fix the file #115

merged 1 commit into from
Feb 13, 2019

Conversation

ostrolucky
Copy link
Member

Not sure why do you ignore my comment at #100 (comment), hopefully you will listen to CI.

@ostrolucky ostrolucky requested a review from a team February 12, 2019 19:44
@Majkl578
Copy link
Contributor

IMO it'd be better to split the script line into two.

@Ocramius Ocramius self-assigned this Feb 13, 2019
@Ocramius Ocramius added this to the 6.0.0 milestone Feb 13, 2019
@Ocramius Ocramius merged commit be7096f into master Feb 13, 2019
@Ocramius Ocramius deleted the ci-fix branch February 13, 2019 06:00
@Majkl578
Copy link
Contributor

Majkl578 commented Feb 13, 2019 •
edited

Hmm I still don't like this [ $? -ne 2 ] approach - we don't use it anywhere (it should be separate if block with a comment ideally). I had to look into source why only code 2 is allowed:
https://github.com/squizlabs/PHP_CodeSniffer/blob/62cd52272e9351f6c9d258e2653ee29e6426456e/src/Runner.php#L205-L227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

@lcobucci lcobucci lcobucci approved these changes

@alcaeus alcaeus alcaeus approved these changes

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees

@Ocramius Ocramius

Labels
Improvement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ostrolucky @Majkl578 @Ocramius @lcobucci @alcaeus @carusogabriel