Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require newline before return #120

Merged
merged 1 commit into from
Mar 15, 2019
Merged

Require newline before return #120

merged 1 commit into from
Mar 15, 2019

Conversation

ostrolucky
Copy link
Member

No description provided.

@ostrolucky ostrolucky requested a review from a team as a code owner March 15, 2019 10:10
@Majkl578
Copy link
Contributor

IMO this case should be allowed:

public function foo(bool $foo) : int
    if ($foo) {
        return 123;
    }

    return 456;
}

@ostrolucky
Copy link
Member Author

@Majkl578 that is allowed, otherwise there would be more violations

@ostrolucky ostrolucky self-assigned this Mar 15, 2019
@Ocramius Ocramius added this to the 6.0.0 milestone Mar 15, 2019
@Ocramius Ocramius merged commit d33f69e into master Mar 15, 2019
@Ocramius Ocramius deleted the newline-return branch March 15, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants