Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for referencing functions and consts in use #16

Merged
merged 2 commits into from
Jan 19, 2018

Conversation

Majkl578
Copy link
Contributor

Test for #15.

  • One unrelated test change to test spacing after !.

Copy link
Member

@lcobucci lcobucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark, but we can make it part of another PR (we might have other stuff to test as well).

@@ -5,8 +5,8 @@
namespace Example;

use Doctrine\Sniffs\Spacing\ControlStructureSniff;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to add another class reference to verify the alphabetical sorting?

@lcobucci lcobucci merged commit 6c40a7c into doctrine:master Jan 19, 2018
@lcobucci lcobucci self-assigned this Jan 19, 2018
@Majkl578 Majkl578 deleted the references-tests branch January 28, 2018 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants