Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Dependabot #160

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Introduce Dependabot #160

merged 2 commits into from
Feb 25, 2020

Conversation

carusogabriel
Copy link
Contributor

Dependabot (https://dependabot.com) is a bot that will help us keep our
dependencies up to date.

This initial configure will open PRs during workdays and working hours (defined in
https://app.dependabot.com) for our PHP Composer dependencies.

No automerge will be performed for now by Dependabot.

alcaeus
alcaeus previously approved these changes Feb 25, 2020
ostrolucky
ostrolucky previously approved these changes Feb 25, 2020
Copy link
Member

@ostrolucky ostrolucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's agree though not to merge these PRs blindly? When slevomat/coding-standard is updated to new major version, it should mean we check their new sniffs and incorporate them. Not just clicking merge button. Doing these checks retroactively is much harder, as we wouldn't know last version we did that for.

@carusogabriel
Copy link
Contributor Author

@ostrolucky Sure. Also, we'd still need the 4 approvals as usual.

deeky666
deeky666 previously approved these changes Feb 25, 2020
Copy link
Member

@deeky666 deeky666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Release notes for dealerdirect/phpcodesniffer-composer-installer: PHPCSStandards/composer-installer@v0.5.0...v0.6.2
Release notes for slevomat/coding-standard: slevomat/coding-standard@6.1.4...6.1.5
Dependabot (https://dependabot.com) is a bot that will help us keep our
dependencies up to date.

This initial configure will open PRs during workdays and working hours (defined in
https://app.dependabot.com) for our PHP Composer dependencies.

No automerge will be performed for now by Dependabot.
@carusogabriel carusogabriel merged commit baae75c into master Feb 25, 2020
@carusogabriel carusogabriel deleted the dependencies/dependabot branch February 25, 2020 17:11
@carusogabriel carusogabriel self-assigned this Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants