Remove PHP 8 from GitHub Actions #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
previously approved these changes
Feb 25, 2020
Why? GH actions doesn't support it? |
@ostrolucky No, it doesn't. |
ostrolucky
previously approved these changes
Feb 25, 2020
Since we still don't support PHP 8 and we can't `allow-failures` on that, let's remove it.
carusogabriel
dismissed stale reviews from ostrolucky and alcaeus
via
0804055
carusogabriel
force-pushed
the
fix/php-8
branch
from
10951ab
to
0804055
Compare
|
Please avoid rebasing when not necessary |
ostrolucky
approved these changes
Feb 25, 2020
You do know that this is necessary due to
right? |
|
No :( |
greg0ire
approved these changes
Feb 25, 2020
alcaeus
approved these changes
Feb 25, 2020
SenseException
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we still don't support PHP 8 and we can't
allow-failureson that, let's remove it.