Ensure that spacing around cases are consistent
#169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't there better alternative than having same input and fixed file? |
morozov
previously approved these changes
Apr 4, 2020
There was a problem hiding this comment.
I'm approving the addition of the configuration as such (thanks, @carusogabriel!) but the #169 (comment) concern needs to be taken into account.
The original issue was that the properly formatted code was reported as containing errors. I don't know if the sniff is supposed to fix it or just not report.
The sniff is just not reporting it, that's why both If you remove the added options in the Ruleset file, it'll break. |
ostrolucky
force-pushed
the
improvement/spacing-case-return
branch
2 times, most recently
from
ca32067
to
05ba49c
Compare
ostrolucky
previously approved these changes
Apr 4, 2020
greg0ire
previously approved these changes
Apr 4, 2020
As reported via slevomat/coding-standard#867, in case that a switch with cases returning or breaking, the `JumpStatementsSpacing` sniff wasn't handling it properly. These 3 new options added ensure that this sniff handles this case as well.
ostrolucky
force-pushed
the
improvement/spacing-case-return
branch
from
05ba49c
to
1f1aa19
Compare
ostrolucky
approved these changes
Apr 4, 2020
morozov
approved these changes
Apr 4, 2020
deeky666
approved these changes
Apr 6, 2020
alcaeus
approved these changes
Apr 6, 2020
|
Thanks @carusogabriel and @morozov for the suggestion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported via slevomat/coding-standard#867, in case that a switch
with cases returning or breaking, the
JumpStatementsSpacingsniffwasn't handling it properly.
These 3 new options ensure that this sniff handles this case as well.
Requested by @morozov via #167 (comment).