Introduce rule requiring Null Coalesce Equal Operator #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Apr 4, 2020
morozov
previously approved these changes
Apr 4, 2020
There was a problem hiding this comment.
AFAIK, the DisallowedShortTernaryRule rule in PHPStan strict rules does about the same regardless of the PHP version. Why is it only for PHP 7.4+ in the coding standard?
kukulich
reviewed
Apr 4, 2020
|
@morozov because ??= exists only in PHP 7.4+ The PHPStan disallows ?:, this sniff requires ??= |
carusogabriel
force-pushed
the
new-rule/null-coalesce-equal-operator
branch
from
373c093
to
f7b4676
Compare
ostrolucky
approved these changes
Apr 4, 2020
SenseException
approved these changes
Apr 4, 2020
morozov
approved these changes
Apr 4, 2020
greg0ire
approved these changes
Apr 4, 2020
|
Thanks @carusogabriel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new rule that will only affect PHP 7.4+ codebases :)