Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead sniffs autoload #176

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Remove dead sniffs autoload #176

merged 1 commit into from
Apr 22, 2020

Conversation

WyriHaximus
Copy link
Contributor

@WyriHaximus WyriHaximus commented Apr 19, 2020 •
edited

Not sure why this is in here, looks like an old relic that was forgotten to remove. Also causes issue with roave/better-reflection when using the MakeLocatorForComposerJsonAndInstalledJson locator factory that assumes any defines autoload paths to exist.

Mutually exclusive with: #177

@WyriHaximus WyriHaximus mentioned this pull request Apr 19, 2020
Closed
@malarzm
Copy link
Member

malarzm commented Apr 19, 2020

Unless we want to keep the entry in put .gitkeep in the said folder?

@WyriHaximus
Copy link
Contributor Author

Unless we want to keep the entry in put .gitkeep in the said folder?

Yes, want a PR for that as well?

@WyriHaximus WyriHaximus mentioned this pull request Apr 19, 2020
Closed
@WyriHaximus
Copy link
Contributor Author

Unless we want to keep the entry in put .gitkeep in the said folder?

Yes, want a PR for that as well?

Filed it at: #177

@greg0ire
Copy link
Member

greg0ire commented Apr 19, 2020 •
edited

That directory was emptied in 69af948, as part of #9

greg0ire
greg0ire approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If people want to contribute Sniffs directly here, I'd rather they do not contribute them in lib. I prefer this PR over #177

@carusogabriel carusogabriel added this to the 8.0.0 milestone Apr 19, 2020
@kukulich
Copy link
Contributor

kukulich commented Apr 20, 2020 •
edited

PHPCS uses its own autoloader so the autoload section is probably useless anyway.

@malarzm malarzm merged commit c9553c3 into doctrine:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

@malarzm malarzm malarzm approved these changes

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees
No one assigned
Labels
Improvement
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@WyriHaximus @malarzm @greg0ire @kukulich @SenseException @carusogabriel