Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8 #192

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Allow PHP 8 #192

merged 1 commit into from
Jun 2, 2020

Conversation

greg0ire
Copy link
Member

We want to allow our users to experiment and report bugs if there are
any.

@greg0ire
Copy link
Member Author

greg0ire commented May 30, 2020 •
edited

Managed to obtain the very same failure as in 7.4… is the current 7.4 build known to be broken? I reproduced the failure locally on 7.0.x

@carusogabriel
Copy link
Contributor

It's broken, slevomat/coding-standard fixed a bug and we need to update the expectations.

Also, is this duplicated from #181?

@greg0ire
Copy link
Member Author

greg0ire commented May 30, 2020 •
edited

I am working on updating the expectations.

This is not a duplicate from #181 : the target branch is not the same, and this does not aim at fixing any issues we might have, or actually supporting php8, it's more of a commitment to support it on the 7.0.x 8.0.x series. This is basically saying that when our dependencies are fixed, we will be fixed.

@greg0ire
Copy link
Member Author

Blocked by #193

@carusogabriel carusogabriel mentioned this pull request May 31, 2020
Merged
@carusogabriel carusogabriel added this to the 8.0.0 milestone May 31, 2020
@greg0ire greg0ire changed the base branch from 7.0.x to master May 31, 2020 21:41
@greg0ire
Allow PHP 8
15d07b9 
We want to allow our users to experiment and report bugs if there are
any.
@greg0ire greg0ire requested review from carusogabriel and a team June 2, 2020 06:42
@greg0ire greg0ire marked this pull request as ready for review June 2, 2020 06:42
@greg0ire greg0ire merged commit 742200e into doctrine:master Jun 2, 2020
@greg0ire greg0ire deleted the php-8 branch June 2, 2020 17:58
@carusogabriel carusogabriel mentioned this pull request Jun 2, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@SenseException SenseException SenseException approved these changes

@carusogabriel carusogabriel carusogabriel approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@greg0ire @carusogabriel @ostrolucky @SenseException