ForbiddenFunctions: Add more basic blackisted aliases #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
Feb 5, 2018
| is_null => null, | ||
| is_real => is_float, | ||
| is_writeable => is_writable, | ||
| join => implode, |
There was a problem hiding this comment.
No clue why but I was always using join :D
alcaeus
approved these changes
Feb 5, 2018
carusogabriel
suggested changes
Feb 5, 2018
| is_double => is_float, | ||
| is_integer => is_int, | ||
| is_long => is_int, | ||
| is_null => null, |
There was a problem hiding this comment.
I suppose it just forbids using is_null without suggesting an alternative function since you should be using === null.
There was a problem hiding this comment.
Yes, if null is provided, then the function is forbidden without alias being suggested, i.e.:
11 | ERROR | The use of function chop() is forbidden; use rtrim() instead
12 | ERROR | The use of function sizeof() is forbidden; use count() instead
13 | ERROR | The use of function is_null() is forbidden
Majkl578
force-pushed
the
sniff/ForbiddenFunctions
branch
2 times, most recently
from
c5f8e7c
to
71dbcdc
Compare
Majkl578
force-pushed
the
sniff/ForbiddenFunctions
branch
from
71dbcdc
to
763783c
Compare
alcaeus
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on http://php.net/manual/en/aliases.php#aliases (thanks @carusogabriel for the link + squizlabs/PHP_CodeSniffer#1838)
Currently contains only Base syntax aliases.
Not auto-fixable. :/