Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ForbiddenComments sniff #24

Closed
wants to merge 1 commit into from
Closed

Enable ForbiddenComments sniff #24

wants to merge 1 commit into from

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Feb 5, 2018

Forbids useless things like:

/** Created by PhpStorm. */
/**
 * Constructor.
 */
/**
 * Foo getter.
 */

Fixable, but with one issue: slevomat/coding-standard#260

@Majkl578 Majkl578 added this to the 3.0.0 milestone Feb 5, 2018
@kukulich
Copy link
Contributor

kukulich commented Feb 5, 2018

https://github.com/slevomat/coding-standard/releases/tag/4.4.0

@Majkl578
Copy link
Contributor Author

Majkl578 commented Feb 5, 2018

@kukulich Passed with 4.4, thanks!

@Majkl578 Majkl578 removed the WIP label Feb 5, 2018
alcaeus
alcaeus approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure I could come up with examples where the expressions would be too loose, but it's not worth it. Let's try them and adjust if they cause trouble. I assume we don't have enough useful comments to trigger these anyways.

@Ocramius Ocramius self-assigned this Feb 6, 2018
@Ocramius Ocramius closed this in bfd472f Feb 6, 2018
@Ocramius
Copy link
Member

Ocramius commented Feb 6, 2018

Manually merged in bfd472f - thanks @Majkl578!

@Majkl578 Majkl578 mentioned this pull request Feb 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees

@Ocramius Ocramius

Labels
New sniff
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Majkl578 @kukulich @Ocramius @alcaeus