Require Null Safe Object operator#255
Merged
greg0ire merged 2 commits intodoctrine:9.0.xfrom Jul 20, 2021
Merged
Conversation
ostrolucky
previously approved these changes
Jul 18, 2021
Contributor
Author
|
I wonder if we should create a patch for PHP 8+. |
SenseException
previously approved these changes
Jul 18, 2021
malarzm
previously approved these changes
Jul 19, 2021
Member
malarzm
left a comment
malarzm
left a comment
There was a problem hiding this comment.
Patch for PHP 8+ (and generally for versions) sounds like a good idea 👍
simPod
dismissed stale reviews from malarzm, SenseException, and ostrolucky
via
3d2ef9a
Contributor
Author
|
I've included #257 so we can have CI passing. So from me this is it. |
ostrolucky
approved these changes
Jul 20, 2021
greg0ire
approved these changes
Jul 20, 2021
malarzm
approved these changes
Jul 20, 2021
Member
|
Thanks @simPod ! |
Member
|
Hmmmmm… 🤔 shouldn't this have targeted 10.x ? |
Contributor
Author
|
hmm, maybe 🧐 can we create it? |
Member
|
Let's revert this, now that the branch exists. Cc @Ocramius |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as we require Null Coalesce operator, this requires Null Safe operator.