[RFC] Add SlevomatCodingStandard.PHP.TypeCast #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
requested review from
Majkl578,
Ocramius,
lcobucci and
alcaeus
carusogabriel
force-pushed
the
typecast
branch
from
07db6a9
to
e91b2fc
Compare
lcobucci
approved these changes
Feb 13, 2018
Majkl578
suggested changes
Feb 13, 2018
alcaeus
approved these changes
Feb 19, 2018
Ocramius
suggested changes
Feb 19, 2018
composer.json
Outdated
| @@ -18,7 +18,7 @@ | |||
| "php": "^7.1", | |||
| "squizlabs/php_codesniffer": "^3.2", | |||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.4.2", | |||
| "slevomat/coding-standard": "^4.4.0" | |||
| "slevomat/coding-standard": "dev-master" | |||
There was a problem hiding this comment.
Requires release before merging
Enforces using shorthand cast operators, forbids usage of unset and binary cast operators: `(bool)` instead of `(boolean)`, `(int)` instead of `(integer)`, `(float)` instead of `(double)` or `(real)`. `(binary)` and `(unset)` are forbidden.
Majkl578
approved these changes
Mar 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: slevomat/coding-standard#284
Found 10 cases of
integercases in ORM, 13 cases ofbooleanin DBAL and 20 cases ofbooleanand 17 ofintegerin mongodb-odm