Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove checkmark on unenforceable rule #36

Merged
merged 1 commit into from
Mar 3, 2018
Merged

Remove checkmark on unenforceable rule #36

merged 1 commit into from
Mar 3, 2018

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Mar 3, 2018

This is not enforced yet, and might never be, cc @kukulich

@Ocramius Ocramius self-assigned this Mar 3, 2018
@Ocramius Ocramius added the bug label Mar 3, 2018
@Ocramius Ocramius added this to the 4.0.0 milestone Mar 3, 2018
Ocramius
Ocramius approved these changes Mar 3, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ocramius Ocramius merged commit 8ae72fd into doctrine:master Mar 3, 2018
@greg0ire greg0ire deleted the remove_checkmark branch March 3, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greg0ire @Ocramius