Forbidden usage of settype function

[carusogabriel]

I'd like to propose the forbidden usage of the settype function. cast should be used instead:

<?php
$foo = '1';

-settype($foo, 'int');
+$foo = (int) $foo;

var_dump($foo); // int(1)

[Majkl578]

Can we also ban gettype()? 🙏

[carusogabriel]

@Majkl578 Isn't gettype helpful in switch statements?

[Majkl578]

No, is_*() should be always preferred.

[carusogabriel]

Isn't a switch prefered instead of elseif?

<?php
$foo = (unknow value);

switch(gettype($foo)) {
    case 'string': /* do someting */;
    case 'int': /* do someting */;
    case 'array': /* do someting */;
}

// vs
if (is_string($foo)) {
  // do something
} elseif (is_int($foo)) {
    // do something
} elseif (is_array($foo)) {
    //do something
}

[Majkl578]

switch (true) {
    case is_string($foo) :
        // do something
    case is_int($foo) :
        // do something
    case is_array($foo) :
        //do something
}

[carusogabriel]

I don't like switch(true) IMHO :(

So feel free to propose it :)

[malarzm]

TIL settype is a thing o.O

[lcobucci]

Can we please add tests to verify this behaviour?

[carusogabriel]

@lcobucci Added 👍

Gosh, I amend the commit, all reviews were gone 🤦‍♂️

[deeky666]

I didn't even know settype() exists. Away with it! gettype() on the other hand is sometimes useful for exception messages though...

[carusogabriel]

@deeky666 Feel free to vote with a review Approving changes 😄