Forbidden usage of extract

[carusogabriel]

I'd like to propose the forbidden usage of the extract function. list should be used instead.

Some reasons are:

• PHPStan does not recognize the extracted variables
• Sometimes we don't want to whole array's indexes, just some of them
• Control of the extract variables names and values

When #39 gets merged, and this one gets approved, list will turn into [] 👍

<?php

$bar = [
    'foo' => 1,
    'bar' => 2,
    'baz' => 3,
];
-extract($bar);
+list($fooValue, $barValue, $bazValue) = $bar;

[Majkl578]

This should not suggest a replacement here, list is not a function (also we use [...] instead of list(...)) so replacement suggestion is not correct imho.

[carusogabriel]

Indeed, as https://php.net/list says:

Like array(), this is not really a function, but a language construct. list() is used to assign a list of variables in one operation.

Thanks, gonna remove it 👍

[Ocramius]

Looking good! Can we also ban compact() (separate PR)?