Remove early return duplicated entry #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Mar 30, 2018
| @@ -17,7 +17,6 @@ and [PSR-2](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2- | |||
| exceptions/differences/extensions (:white_check_mark: are the implemented sniffs): | |||
|
|
|||
| - Keep the nesting of control structures per method as small as possible | |||
| - Prefer early exit over nesting conditions or using else | |||
There was a problem hiding this comment.
This wording is maybe a little bit more clear than the one a few line down. What do you think ?
There was a problem hiding this comment.
@mikeSimonson Good idea, gonna use it :)
alcaeus
previously approved these changes
Mar 30, 2018
Ocramius
approved these changes
Mar 30, 2018
malarzm
approved these changes
Mar 31, 2018
Majkl578
approved these changes
Apr 1, 2018
mikeSimonson
approved these changes
Apr 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mentioned that a few lines down with a sniff implemented 馃憤