Add Sniff to report useless variables #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
force-pushed
the
useless-variables
branch
from
44675dc
to
5acb1f4
Compare
carusogabriel
changed the title
alcaeus
previously approved these changes
Aug 25, 2018
Declared variable that are return right after it, should be inline
carusogabriel
force-pushed
the
useless-variables
branch
from
5acb1f4
to
7a72add
Compare
carusogabriel
requested review from
Ocramius,
lcobucci,
alcaeus,
FabioBatSilva,
jwage,
malarzm,
morozov,
ostrolucky and
a team
morozov
approved these changes
Aug 26, 2018
ostrolucky
approved these changes
Aug 26, 2018
jwage
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A declared variable that is return right after it, should be inline:
function foo() { - $foo = 'bar'; - - return $foo; + return 'bar'; }