Add Sniff to reported unused variables passed to closures #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
commented
Aug 27, 2018
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I've created a new test file to help us test future unused variables in functions scopes 👍
alcaeus
previously approved these changes
Aug 27, 2018
malarzm
previously approved these changes
Aug 27, 2018
carusogabriel
force-pushed
the
unused-variables-closures
branch
from
2d0e0ba
to
859b4c9
Compare
carusogabriel
requested review from
deeky666,
lcobucci,
alcaeus,
jwage,
malarzm,
morozov,
ostrolucky and
a team
alcaeus
approved these changes
Aug 28, 2018
malarzm
approved these changes
Aug 28, 2018
ostrolucky
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.