Validate ruleset against XML schema #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤔 maybe you meant to link to something else, because this seems to be about ignore patterns… or maybe I lack the context to understand what this has to do with type conversion. |
Fixed, that one was from master (so wrong line numbers) which is even more magical. 😁 |
greg0ire
approved these changes
Sep 3, 2018
jwage
approved these changes
Sep 3, 2018
SenseException
approved these changes
Sep 3, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate against XML Schema on CI.
type="boolean"has apparently no effect:https://github.com/squizlabs/PHP_CodeSniffer/blob/3.1.1/src/Ruleset.php#L925-L982
and type conversion is done by magic instead: https://github.com/squizlabs/PHP_CodeSniffer/blob/3.1.1/src/Ruleset.php#L1232-L1253