Document how to customize rules #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also can I easily test this locally (build the docs from my PR)? |
Majkl578
force-pushed
the
customizing-rules
branch
from
ef455d1
to
99d1ad8
Compare
|
Yes, go to the projects/coding-standard folder in your doctrine-website clone and checkout your clone & branch. Run |
Majkl578
force-pushed
the
customizing-rules
branch
from
99d1ad8
to
2428e12
Compare
alcaeus
reviewed
Sep 4, 2018
docs/en/reference/customizing.rst
Outdated
| <!-- set soft line length limit to 120 characters --> | ||
| <property name="lineLimit" value="120"/> | ||
| <!-- set hard line length limit to 120 characters --> | ||
| <property name="absoluteLineLimit" value="160"/> |
There was a problem hiding this comment.
Mismatch to documentation (120 vs. 160)
greg0ire
reviewed
Sep 4, 2018
docs/en/reference/customizing.rst
Outdated
| Adding new rules | ||
| ---------------- | ||
|
|
||
| Add new rules is simple, all you need to do is add a new ``<rule>`` block: |
greg0ire
reviewed
Sep 4, 2018
docs/en/reference/index.rst
Outdated
| Project-level ruleset | ||
| ===================== | ||
|
|
||
| To enable Doctrine Coding Standard for your project, create ``phpcs.xml.dist`` file with the following content: |
greg0ire
reviewed
Sep 4, 2018
docs/en/reference/index.rst
Outdated
| <file>lib</file> | ||
| <file>tests</file> | ||
|
|
||
| <!-- Include whole Doctrine Coding Standard --> |
greg0ire
reviewed
Sep 4, 2018
Majkl578
force-pushed
the
customizing-rules
branch
from
2428e12
to
fa12b40
Compare
Majkl578
force-pushed
the
customizing-rules
branch
from
fa12b40
to
059fe5e
Compare
jwage
approved these changes
Sep 4, 2018
Majkl578
requested review from
alcaeus,
greg0ire,
carusogabriel,
Ocramius and
SenseException
greg0ire
approved these changes
Sep 4, 2018
SenseException
approved these changes
Sep 4, 2018
alcaeus
approved these changes
Sep 5, 2018
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpcs.xml(.dist)?@jwage Can you please proofread this? Thanks.