Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid psalm type inference for ArrayCollection#map() #210

Closed
someniatko opened this issue Oct 25, 2019 · 5 comments
Closed

Invalid psalm type inference for ArrayCollection#map() #210

someniatko opened this issue Oct 25, 2019 · 5 comments
Assignees
@someniatko
Labels
Bug
Milestone
1.6.3

Comments

@someniatko
Copy link
Contributor

someniatko commented Oct 25, 2019 •
edited
Loading

Similar to #200 but about map() method.

I have created a reproduction repository: https://github.com/someniatko/doctrine-collections-map-psalm

doctrine/collections: v1.6.2
vimeo/psalm: 3.6.2
@someniatko someniatko changed the title Invalid psalm type inferrence for ArrayCollection#map() Invalid psalm type inference for ArrayCollection#map() Oct 25, 2019
@greg0ire
Copy link
Member

greg0ire commented Oct 25, 2019 •
edited
Loading

I'm afraid v1.6.2 does not contain the fixed for #200 , but I could be wrong, please check, I will reopen otherwise

@someniatko
Copy link
Contributor Author

someniatko commented Oct 25, 2019 •
edited
Loading

@greg0ire It contains the fix.
Pull request #201 says "fixes #200", this PR contains commit 5945173 which is present in the commit tree of the tag v1.6.2

@greg0ire greg0ire reopened this Oct 25, 2019
@greg0ire
Copy link
Member

greg0ire commented Oct 25, 2019 •
edited
Loading

That's correct! I'm not sure why v1.6.2 does not show up on this page: 5945173 , but git tag --contains 59451730480c1d87f777a3a4cee4653251be8457 says you're right!

someniatko pushed a commit to someniatko/collections that referenced this issue Oct 28, 2019
fix doctrine#210 by including psalm-* annotations to ArrayCollection#…
763af60 
…map() method
@someniatko someniatko mentioned this issue Oct 28, 2019
Merged
Ocramius added a commit that referenced this issue Oct 28, 2019
@Ocramius
Merge pull request #211 from someniatko/fix-psalm-arraycollection-map
09deece 
fix #210 by including psalm-* annotations to ArrayCollection#map()
@Ocramius Ocramius added the Bug label Oct 28, 2019
@Ocramius Ocramius added this to the 1.6.2 milestone Oct 28, 2019
@someniatko
Copy link
Contributor Author

@Ocramius Hasn't 1.6.2 already been released?
https://github.com/doctrine/collections/releases/tag/v1.6.2

@Ocramius
Copy link
Member

Aye, milestone is wrong, thanks for noticing!

@Ocramius Ocramius reopened this Oct 28, 2019
@Ocramius Ocramius modified the milestones: 1.6.2, 1.6.3 Oct 28, 2019
@someniatko someniatko mentioned this issue Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@someniatko someniatko

Labels
Bug
Projects
None yet
Milestone
1.6.3
Development

No branches or pull requests
3 participants
@Ocramius @greg0ire @someniatko